Hmm.. I haven't played much of Super Mario Advance.. just a copy of the ROM (I don't know where to get it, don't ask me).
I thought it was good, but I can see why people would have wanted an option to turn the voices off in that game. A voice clip for every little detail was insane (plucking a veggie, being hit, grabbing a cherry, grabbing an enemy..). I did like Toad's voice, though.
My favorite one is probably the first game he had a voice in, Mario Kart 64 (ok, so this was the first famous one.. he first had a voice in Wario's Woods..) After that, we didn't hear much from the World's greatest mushroom retainer.. Just some ohs and aws in the first 3 Mario Party games, then he was given what was an ok voice in MP4. MKDD was a good voice, but not as good as MK64, and MP's 5-6 are also pretty good, but again, not as good as MK64's.